drei icon indicating copy to clipboard operation
drei copied to clipboard

removed sRGBToLinear from MeshReflectorMaterial

Open b4sh-3r opened this issue 3 years ago • 5 comments

Why

To solve: ERROR: 0:1323: 'sRGBToLinear' : no matching overloaded function found

What

I removed the "sRGBToLinear" part highlighted by @paulhenschel from the MeshReflectorMaterial

Checklist

  • [ ] Documentation updated
  • [ ] Storybook entry added
  • [X ] Ready to be merged

b4sh-3r avatar Feb 09 '22 09:02 b4sh-3r

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/drei/EG7bDrVNQoHdXZKa2sZaK2tbsniH
✅ Preview: https://drei-git-fork-b4sh-3r-remove-srgbtolinear-from-me-286a68-pmndrs.vercel.app

vercel[bot] avatar Feb 09 '22 09:02 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 02efc4cace9ce0383844b3711f032c3703a6cbdb:

Sandbox Source
confident-moon-3eiipt Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration

codesandbox-ci[bot] avatar Feb 09 '22 09:02 codesandbox-ci[bot]

imo the debug modes just prevent shader branching, no? i would be ok with them going out. i think i already removed them in some other shader.

drcmda avatar Jul 23 '22 19:07 drcmda

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
drei ✅ Ready (Inspect) Visit Preview Jul 23, 2022 at 7:53PM (UTC)

vercel[bot] avatar Jul 23 '22 19:07 vercel[bot]

close as stale?

FarazzShaikh avatar Jul 29 '22 16:07 FarazzShaikh