drei icon indicating copy to clipboard operation
drei copied to clipboard

fix(MeshReflectorMaterial): avoid updates when possible

Open davcri opened this issue 1 year ago • 1 comments

Why

These changes avoids unnecessary updates for MeshReflectorMaterial. Previously it was updating even with visible=false on the material or on the parent mesh.

A couple of notes:

  1. I had to update three and @types/three package because onBeforeRender() method was not typed correctly up til https://github.com/three-types/three-ts-types/pull/1169 and it was causing errors
  2. sorry I disabled Husky locally as I was getting a lot of errors that were not related to these changes

davcri avatar Feb 24 '25 22:02 davcri

@davcri is attempting to deploy a commit to the Poimandres Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Feb 24 '25 22:02 vercel[bot]