drei icon indicating copy to clipboard operation
drei copied to clipboard

fix: Line accepts readonly points and vertex colors

Open RodrigoHamuy opened this issue 1 year ago • 6 comments

Why

Currently this will give TS errors:

import { Line } from "@react-three/drei";
const points: readonly [number, number][] = [[0,0], [0,1]];
const MyLine = ()=> <Line points={points} />

What

Updated the types so it accepts also readonly arrays.

This doesn't mean that you need to pass immutable arrays now, just means that <Line> can now accept both rather than just mutable ones.

Checklist

  • [x] Ready to be merged

RodrigoHamuy avatar Jul 26 '24 16:07 RodrigoHamuy

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 1:42pm

vercel[bot] avatar Jul 26 '24 16:07 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Jul 26 '24 16:07 codesandbox-ci[bot]

I think the image snapshot test is failing due to an update to the test docker image. @abernier https://github.com/pmndrs/playwright/commit/3f65c314ca74c1d315295b08d2d0047350e57de1

RodrigoHamuy avatar Jul 29 '24 09:07 RodrigoHamuy

ah yes, missed that, will fix

abernier avatar Jul 29 '24 12:07 abernier

should be fixed

abernier avatar Jul 29 '24 13:07 abernier

@RodrigoHamuy is attempting to deploy a commit to the Poimandres Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Aug 08 '24 14:08 vercel[bot]

:tada: This PR is included in version 9.112.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Sep 20 '24 11:09 github-actions[bot]