drei icon indicating copy to clipboard operation
drei copied to clipboard

[feat] update for R3F v9

Open krispya opened this issue 9 months ago • 7 comments

This is untested. It is a quick conversion of Drei v9 to use R3F v9 without any typing errors.

krispya avatar Apr 29 '24 02:04 krispya

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 6:40pm

vercel[bot] avatar Apr 29 '24 02:04 vercel[bot]

@joshuaellis I'd like to appeal to you about upgrading react-spring for R3F v9. :)

krispya avatar Apr 29 '24 02:04 krispya

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar May 08 '24 17:05 codesandbox-ci[bot]

Now builds. Known issues are with components that access R3F internals like RenderTexture.

krispya avatar May 08 '24 17:05 krispya

@joshuaellis I'd like to appeal to you about upgrading react-spring for R3F v9. :)

Sorry I missed this. Do you know what the impact looks like? I can probably find some time for you haha

joshuaellis avatar May 08 '24 17:05 joshuaellis

@joshuaellis I'd like to appeal to you about upgrading react-spring for R3F v9. :)

Sorry I missed this. Do you know what the impact looks like? I can probably find some time for you haha

I believe it is just types, maybe related to this: https://react.dev/blog/2024/04/25/react-19-upgrade-guide#the-jsx-namespace-in-typescript

We also moved types for R3F to ThreeElements.

krispya avatar May 08 '24 18:05 krispya

@CodyJasonBennett I'm stuck again getting the test to run. Some kind of source map issue.

krispya avatar May 21 '24 18:05 krispya