drei icon indicating copy to clipboard operation
drei copied to clipboard

Fix callback type of `onChanged` prop in `<CycleRaycast />`

Open lr0pb opened this issue 10 months ago • 2 comments

Why

I found strange that event callback type in <CycleRaycast /> component needed to return null instead more suitable in this case void

What

Change onChanged callback type in <CycleRaycast /> component to return void instead of null. Also copy <CycleRaycast /> props descriptions from official docs into JSDoc annotations & fix JSDoc annotations for <DragControls /> component

Checklist

  • [x] Ready to be merged

lr0pb avatar Apr 18 '24 13:04 lr0pb

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 1:20pm

vercel[bot] avatar Apr 18 '24 13:04 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Apr 18 '24 13:04 codesandbox-ci[bot]