drei icon indicating copy to clipboard operation
drei copied to clipboard
verified publisher icon pmndrs

feat: PivotControls scaling

Open STINGNAILS opened this issue 3 years ago • 12 comments

Why

Issue 1046

What

Added scaling spheres to the PivotControls

Checklist

  • [ ] Link codesandbox
  • [ ] Documentation updated
  • [ ] Storybook entry added
  • [x] Ready to be merged

STINGNAILS avatar Jan 26 '23 08:01 STINGNAILS

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 0:12am

vercel[bot] avatar Jan 26 '23 08:01 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7ec0e2c62221931483fee4dbcf85fa427a2801ae:

Sandbox Source
awesome-tu-r33xhf Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration

codesandbox-ci[bot] avatar Jan 26 '23 08:01 codesandbox-ci[bot]

does it merge into master ?

skypu3 avatar May 09 '23 05:05 skypu3

Hey, this is really useful and exactly what I need for something I am working on. Any idea when/if this will be released on the main branch?

AdamLeBlanc avatar Sep 11 '23 00:09 AdamLeBlanc

the scale deforms the pivot controls

image

Is this fixable?

joaomelorodrigues avatar Oct 11 '23 19:10 joaomelorodrigues

Hello, just checking on the eta for this feature on the main branch. Thanks

abhirakshit avatar Jan 10 '24 18:01 abhirakshit

Hi just wondering when this is gonna be merged, thanks.

mjlever1991 avatar Jan 24 '24 12:01 mjlever1991

+1

mbxxr avatar Jan 24 '24 12:01 mbxxr

+1

joaomelorodrigues avatar Jan 24 '24 13:01 joaomelorodrigues

Ok, will check into the mentioned issue with deforming within a week and ask for merging it, sorry for the delay...

STINGNAILS avatar Jan 24 '24 13:01 STINGNAILS

Great. How do we use this? Does it need to be merged with main Drei branch or is there another way to use this?

mjlever1991 avatar Feb 06 '24 22:02 mjlever1991

Great. How do we use this? Does it need to be merged with main Drei branch or is there another way to use this?

Same question :)

joaomelorodrigues avatar Feb 15 '24 22:02 joaomelorodrigues

Excited to push a project forward with this, any idea when we can expect it to be merged?

mbxxr avatar Mar 03 '24 11:03 mbxxr

thanks @STINGNAILS ! @cyango @mjlever1991 @mbxxr

drcmda avatar Mar 07 '24 08:03 drcmda

:tada: This PR is included in version 9.100.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Mar 07 '24 08:03 github-actions[bot]

I tested this today with latest versions of three.js, r3f and drei. Issue still happening: https://codesandbox.io/p/sandbox/object-gizmo-controls-forked-s5v6hd?file=%2Fsrc%2FApp.js%3A6%2C1

joaomelorodrigues avatar May 08 '24 07:05 joaomelorodrigues