drei icon indicating copy to clipboard operation
drei copied to clipboard

fix: selection state missing when dragging transforms pointerup

Open m1911star opened this issue 3 years ago • 2 comments

Why

bug: selection state loss when dragging transforms pointer up

I think it's better to keep that state

Before

https://user-images.githubusercontent.com/4948120/182520782-9df2385d-66f6-4cb2-bf9a-fdc56a53c48d.mov

After

https://user-images.githubusercontent.com/4948120/182520856-7b55ef33-de3d-4afa-818b-35350c84f4b6.mov

What

The problem is that onClick triggered improperly, so I use onPointerDown onPointerUp onPointerMove to simulate onClick

Checklist

  • [x] Documentation updated (no need for that)
  • [x] Storybook entry added
  • [x] Ready to be merged

m1911star avatar Aug 03 '22 03:08 m1911star

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
drei ✅ Ready (Inspect) Visit Preview Dec 20, 2022 at 6:04AM (UTC)

vercel[bot] avatar Aug 03 '22 03:08 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1f1da7943d3d140a561947c22b8b02a4139f9787:

Sandbox Source
ecstatic-wildflower-tst3hg Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration

codesandbox-ci[bot] avatar Aug 03 '22 04:08 codesandbox-ci[bot]