ext-pmmpthread icon indicating copy to clipboard operation
ext-pmmpthread copied to clipboard

Incorrect copying of internal functions from extensions loaded via dl

Open AndrewKusov opened this issue 2 years ago • 1 comments

Environment

  • PHP: 8.2.4
  • pthreads: 6.0.2
  • OS: Windows 8.1 x64
  • OPcache: no

Summary

Extensions imported using dl in the main thread incorrectly copy functions to the one created using the extension, although the extension is connected. The problem is solved only if you manually register module_entry->functions in pthreads_prepared_startup, according to the code from zend_register_module_ex

Reproducing Code

dl('mbstring'); //////////

use pmmp\thread\Thread as Thread;
$thread = new class extends Thread
{
	public function run() : void
	{
		print_r(mb_strtolower('text'));
	}
};
$thread->start(Thread::INHERIT_ALL) && $thread->join();

Expected Output

text

Actual Output

Call to undefined function mb_strtolower

AndrewKusov avatar Jun 07 '23 06:06 AndrewKusov

Currently the extension assumes that all functions will be automatically present on other threads. dl() was never considered. To be honest, I'm not actually 100% sure it makes sense for dl() to affect other threads anyway.

dktapps avatar Jun 19 '23 13:06 dktapps