PocketMine-MP icon indicating copy to clipboard operation
PocketMine-MP copied to clipboard

Block suddenly appears during Bridge

Open nzAily opened this issue 1 year ago • 11 comments

Plugin information

I haven't tested without plugins

Problem description

there in the video

https://github.com/user-attachments/assets/c42846c5-c85f-403d-85fa-a78fe2eab792

Expected behaviour

as normal you can see the video below i tried it in my own world

https://github.com/user-attachments/assets/7d024a15-8cc6-40ea-8d60-579df25648a4

PocketMine-MP version

5.23.2

PHP version

8.2.17

Server OS

win

Game version (if applicable)

Windows 1.21.51

nzAily avatar Jan 04 '25 02:01 nzAily

Can vouch that this has been happening a LOT more, specially when owning a bridge server

iAmFrogger avatar Jan 04 '25 21:01 iAmFrogger

I can also vouch for this happens, I have a minigame server and people get very upset about this

Josscoder avatar Jan 06 '25 15:01 Josscoder

I figured out that when you bridge like that but you look down it wont happen or when you bridge like that forward without jumping it doesn't happen. - a temporary solution

Trollserver avatar Jan 09 '25 16:01 Trollserver

If I had to guess, I'd say this was likely caused by ff695a5f97182226d9c7d28ac317128672fc9fce, since it changed block syncing to always happen on right-click, instead of only on failed actions.

Not sure how else we could achieve this without BC breaks though. Since the client doesn't tell us what blocks it thinks have changed, we need to guess whether the result action of the interaction was the same as the client expected. It seemed like it was simpler to not guess since the introduction of ff695a5f97182226d9c7d28ac317128672fc9fce. Bringing back the guesswork logic would be complicated because ff695a5f97182226d9c7d28ac317128672fc9fce introduces new ways for an action to succeed without following vanilla.

dktapps avatar Jan 09 '25 20:01 dktapps

I don't really understand the code that much and what changed so I wanna ask if I can somehow undo the change and if it would break something?

Trollserver avatar Jan 10 '25 06:01 Trollserver

Yes it would break things. That's why it hasn't been reverted by the team already.

dktapps avatar Jan 10 '25 14:01 dktapps

image

I don't know if it will help, but reverting these lines will prevent the error from happening again. It's a temporary solution while they fix the bug.

Josscoder avatar Jan 12 '25 19:01 Josscoder

has this issue been fixed?

nzAily avatar Feb 24 '25 03:02 nzAily

No

dktapps avatar Feb 24 '25 13:02 dktapps

has this issue been fixed?

No, but you can use a temporary solution offered by this plugin: https://poggit.pmmp.io/p/BridgeBlockFix/1.0.0

Josscoder avatar Feb 24 '25 14:02 Josscoder

image

I don't know if it will help, but reverting these lines will prevent the error from happening again. It's a temporary solution while they fix the bug.

but i used this solution and it worked but i don't know if this will be safe later but so far, i've tried to play it safe until now

nzAily avatar Feb 27 '25 06:02 nzAily