PocketMine-MP icon indicating copy to clipboard operation
PocketMine-MP copied to clipboard

Support excluding more than one recipient in `Command::broadcastCommandMessage()`

Open MrBlasyMSK opened this issue 3 years ago • 4 comments

Issue description

If you send a message to a player with /tell, the player who receives the message, apart from receiving what you have written, will add another message with something else added and in English.

Example:

I write

/tell "name" This is a test

He receives

"name" whispers to you: This is a test ["name": You whisper to "name": This is a test]

  • Expected result: That the English message did not appear
  • Actual result: That the player to whom the private message is sent receives this when he does not contribute anything.

Steps to reproduce the issue

  1. Use /tell whit anyone
  2. See the error

OS and versions

  • This server is running PocketMine-MP
  • Server version: 4.2.3 (git hash: 6c1c0c867e178f8da8b266e962ca13f4b4280ab4)
  • Compatible Minecraft version: 1.18.10 (protocol version: 486)
  • PHP version: 8.0.16
  • PHP JIT: not supported
  • Operating system: linux
  • Game version: Win10

Plugins

0 plugins

  • If you remove all plugins, does the issue still occur? Yes
  • If the issue is not reproducible without plugins:
    • Have you asked for help on our forums before creating an issue?
    • Can you provide sample, minimal reproducing code for the issue? If so, paste it in the bottom section

Crashdump, backtrace or other files

MrBlasyMSK avatar Mar 16 '22 16:03 MrBlasyMSK

Captura de pantalla (473)

MrBlasyMSK avatar Mar 16 '22 16:03 MrBlasyMSK

This occurs if the recipient is an operator.

dktapps avatar Mar 16 '22 16:03 dktapps

This occurs if the recipient is an operator.

Is there any way to disable this?

MrBlasyMSK avatar Mar 16 '22 16:03 MrBlasyMSK

This would require a replacement for Command::broadcastCommandMessage(), or a BC break to its signature.

dktapps avatar May 21 '22 16:05 dktapps