PocketMine-MP icon indicating copy to clipboard operation
PocketMine-MP copied to clipboard

Implements Noteblocks and extra instruments

Open Aericio opened this issue 4 years ago • 3 comments

Introduction

This PR implements noteblock functionality and adds more instruments.

Relevant issues

N/A

Changes

API changes

Added Block::getNoteblockInstrument() - this determines what instrument noteblocks placed on top of the block shoud sound like. Added the $noteblockInstrument constructor parameter to the Block class - this is of type NoteInstrument and determines the return value of the function above.

Behavioural changes

Made noteblocks work.

Backwards compatibility

N/A

Follow-up

N/A

Tests

https://youtu.be/Z5Gks2oEtYk

Aericio avatar Jul 02 '20 05:07 Aericio

This looks mostly OK, but I'm not a fan of the big blockIDs switch, I'm trying to migrate away from those.

dktapps avatar Jul 02 '20 11:07 dktapps

Sorry, I didn't test any changes, I don't know why I'm getting this error when I try to run the server.

Fatal error: Cannot declare class pocketmine\VersionInfo, because the name is already in use in D:\SAMSUNG_T5\Minecraft PE\src\VersionInfo.php on line 30

Aericio avatar Aug 09 '20 04:08 Aericio

You need to update your composer dependencies & autoloader every time you pull changes.

dktapps avatar Aug 09 '20 09:08 dktapps