PocketMine-MP icon indicating copy to clipboard operation
PocketMine-MP copied to clipboard
verified publisher icon pmmp

Illager banner in creative inventory places a normal white banner

Open dktapps opened this issue 6 years ago • 6 comments

Issue description

Illager banner appears to use a non-standard method to define its pattern in NBT, which is not recognized by PM. This leads to the placement of a regular white banner when placing an illager banner.

This is considered a bug because the item appears in the creative inventory, but doesn't work as designed.

Steps to reproduce the issue

  1. Get an illager banner from the creative inventory.
  2. Place it and notice it turns white.

OS and versions

  • PocketMine-MP: 3.8.3, master
  • PHP: 7.3.5
  • Server OS: linux
  • Game version: all

dktapps avatar Jun 01 '19 11:06 dktapps

I noticed that too 🤔

Wertzui123 avatar Jun 12 '19 12:06 Wertzui123

can't we not just add in src/pocketmine/tile/Banner.php PATTERN_ILLAGER and add the colors to it

Jean-TKG avatar Jul 18 '19 22:07 Jean-TKG

No, it's not that simple. Mojang specialized this one for reasons I'm not clear on.

dktapps avatar Jul 19 '19 07:07 dktapps

oh ok

Jean-TKG avatar Jul 19 '19 10:07 Jean-TKG

Okey.

Wertzui123 avatar Jul 19 '19 20:07 Wertzui123

With the new serializer architecture in PM5, it should be possible to implement this as a separate item, avoiding the conditionally useless / broken pattern APIs for illager banners.

dktapps avatar Mar 26 '23 13:03 dktapps