Facing and Axis to enum

Open Dhaiven opened this issue 2 years ago • 4 comments

Fix #89

This change requires many changes in pmmp. I can do if this pr is good for you.

Nov 19 '23 14:11 Dhaiven

If we're going with enums I would prefer to ditch the numeric values entirely. They have no purpose except to be implicitly misused as Minecraft constants.

Nov 20 '23 18:11 dktapps

If we're going with enums I would prefer to ditch the numeric values entirely. They have no purpose except to be implicitly misused as Minecraft constants.

Should I do the same for Axis? I don't know if these values represent anything or not

Nov 20 '23 20:11 Dhaiven

If we're going with enums I would prefer to ditch the numeric values entirely. They have no purpose except to be implicitly misused as Minecraft constants.

Should I do the same for Axis? I don't know if these values represent anything or not

Yes

Nov 21 '23 09:11 dktapps

This pr is good ? if yes i can change pocketmine to support Facing enum

May 12 '24 16:05 Dhaiven