BedrockProtocol icon indicating copy to clipboard operation
BedrockProtocol copied to clipboard

Published 20 hours ago • verified publisher icon pmmp

BossEventPacket PR for colors missed a field

Open inxomnyaa opened this issue 1 year ago • 1 comments

Introduced in https://github.com/pmmp/BedrockProtocol/commit/c9e1f76670d3097d3978abf33b8673bc93961ec6

https://github.com/pmmp/BedrockProtocol/blob/b455a742779fee94d25f931cc2cbf6b2c5d61c1f/src/BossEventPacket.php#L100 should be

-		$result->color = 0; //hardcoded due to being useless
+		$result->color = $this->color;

inxomnyaa avatar Oct 26 '22 21:10 inxomnyaa

You can't use $this inside a static method. An extra parameter would have to be added.

dktapps avatar Oct 26 '22 21:10 dktapps