Paulo Lopes

Results 348 comments of Paulo Lopes

For the record, the reason why the test was disabled was because the fixture test suite, was not the official openapi test suite. Given that the new implementation uses the...

It looks you're missing some header files in your system or their paths added to the includes check if you have the file "gl.h"

Tagging @tsegismont for his input here.

Hi @kostya05983 I think an arangodb client vert.x friendly is a good addition to the ecosystem. I've spent some time looking at your repo and before I give my thumbs...

Could you try to identify why isn't this code being executed: https://github.com/vert-x3/vertx-web/blob/4e9e2c40e0843e7abb4ddc8feae021cdb17d6a41/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/AuthenticationHandlerImpl.java#L129

I saw it wrong, I think @bfreuden fix is correct. the missing check on 302 looks correct. Maybe you can add it and a test to verify the behavior?

@tsegismont yeap, that's correct, platform wouldn't allow anything before (other than another platform) protocol upgrade is a better suited interface. The unspoken contract is that if the handler performs any...

You can also add another interface to cleary mark proxy related stuff if `protocol upgrade` seems odd. There is no cost as the check only happens once in the lifecycle...