Petar Mlinarić
Petar Mlinarić
> For now, I went with a structure similar to the DMD implementation. I would say that you don't have to follow the DMD implementation (it is more similar to...
@artpelling What do you think about making this PR independent of the presets and randomized LA pull requests? It might take a while before those are merged. For now, you...
ERA would be the first data-driven reductor (excluding DMD, which is actually not available as a reductor), so I don't think you need to worry about what other reductors look...
I moved now the configuration from `setup.cfg` to `pyproject.toml`. You could find that running `pylint` on `src/` with default options (e.g., `pylint --rcfile=setup.cfg src`) returns "Your code has been rated...
> > I also realized that `.pylintrc` has even higher priority that `pyproject.toml` (see [here](https://pylint.pycqa.org/en/stable/user_guide/run.html#command-line-options)), so using that should be fine for my use case (without any changes to pyMOR)....
> Is this, minus the conflicts, ready to merge then? No no, it's not ready. I turned it into a draft PR now. There are still a bunch of warnings...
Here is the result of running `pylint src`: [pylint_results.txt](https://github.com/pymor/pymor/files/8871243/pylint_results.txt)
Ignoring similar lines reduced the pylint report from 3724 lines to 2064 lines: [pylint_results.txt](https://github.com/pymor/pymor/files/9085824/pylint_results.txt)
I'm worried about adding dependencies. Which licenses do these projects use? When I tried to download the HSL code, it asks if I want a personal academic or a commercial...
Looks good to me so far. Would you also add `seed` to `adaptive_rrf`? Hopefully, this doesn't cause strange git conflicts with #1552...