typescript-tools.nvim icon indicating copy to clipboard operation
typescript-tools.nvim copied to clipboard

feat: implement `Move to file` code action

Open pmizio opened this issue 1 year ago • 4 comments

TODO:

  • [ ] config option to pass other telescope builtin pickers (default find_files)
  • [ ] config option to pass custom function as file picker(allow to use other things than telescope)

pmizio avatar Jan 17 '24 08:01 pmizio

Hello! Is there any plan to merge this? I'm happy to help test if that would be useful.

mmirus avatar Mar 08 '24 15:03 mmirus

Yes please! I had fun using this in VSCode

foodornt avatar May 11 '24 12:05 foodornt

It works great! there is just one issue where if the target file does not have a newline at the end (or i guess, technically speaking, that would be, two newlines at the end), stuff you're moving doesnt land in there. That's the main big bug i found over the past couple months daily driving this (i use it in bursts once every few weeks).

unphased avatar Aug 08 '24 18:08 unphased

@unphased I've might have fixed this problem. Can you check if the fix works for you?

KostkaBrukowa avatar Aug 19 '24 08:08 KostkaBrukowa

Any update? Can we get this merged?

kloczewiak avatar Nov 11 '24 16:11 kloczewiak

I think we should go ahead with this. I tried to look up the vim.lsp.util.apply_workspace_edit API but I can't find any more information about what a WorkspaceEdit is...

unphased avatar Nov 11 '24 17:11 unphased

Would love to get this as well, thanks! 😍 Until then I'll just point to this branch and report back if there are any issues 🙌

marcesengel avatar Nov 20 '24 09:11 marcesengel