pmix-standard icon indicating copy to clipboard operation
pmix-standard copied to clipboard

First pass at IAWG pass at pack/unpack chapter

Open dsolt opened this issue 2 years ago • 4 comments

Signed-off-by: David Solt [email protected]

dsolt avatar Apr 24 '23 17:04 dsolt

Outstanding issues not addressed yet in the PR:

  • Use of calloc/free in macros and in PMIx_data_load, No means to free the data allocated by PMIx_Data_compress and decompress
  • “These errors cannot be detected during packing” - not sure what to do with this.
  • Text talks about resetting the unpack_ptr, but there is no macro to do that.
  • If more values exist in the buffer than can fit into the memory storage, then the function will unpack what it can fit into that location and return an error code indicating that the buffer was only partially unpacked.
  • Why PMIx_data_compress does not take a byte object
  • data_embed and data_load names could be improved. (copy and move?)
  • should the whole chapter be moved later in the document since its not really core pmix functionality

dsolt avatar Apr 24 '23 18:04 dsolt

Please use emoji reactions ON THIS COMMENT to indicate your position on this proposal.

  • You do not need to vote on every proposal
  • If you have no opinion, don't vote - that is also useful data
  • If you've already commented on this issue, please still vote so we know your current thoughts
  • Not all proposals solve exactly the same problem, so we may end up accepting proposals that appear to have some overlap This is not a binding majority-rule vote, but it will be a very significant input into the corresponding ASC decision.

Here are the meanings for the emojis:

  • Hooray or Rocket: I support this so strongly that I want to be an advocate for it
  • Heart: I think this is an ideal solution
  • Thumbs up: I'd be happy with this solution
  • Confused: I'd rather we not do this, but I can tolerate it
  • Thumbs down: I'd be actively unhappy, and may even consider other technologies instead If you want to explain in more detail, feel free to add another comment, but please also vote on this comment.

dsolt avatar Apr 11 '24 18:04 dsolt

Please use emoji reactions ON THIS COMMENT to indicate your position on this proposal.

  • You do not need to vote on every proposal
  • If you have no opinion, don't vote - that is also useful data
  • If you've already commented on this issue, please still vote so we know your current thoughts
  • Not all proposals solve exactly the same problem, so we may end up accepting proposals that appear to have some overlap This is not a binding majority-rule vote, but it will be a very significant input into the corresponding ASC decision.

Here are the meanings for the emojis:

  • Hooray or Rocket: I support this so strongly that I want to be an advocate for it
  • Heart: I think this is an ideal solution
  • Thumbs up: I'd be happy with this solution
  • Confused: I'd rather we not do this, but I can tolerate it
  • Thumbs down: I'd be actively unhappy, and may even consider other technologies instead If you want to explain in more detail, feel free to add another comment, but please also vote on this comment.

dsolt avatar Jul 04 '24 01:07 dsolt

PR449 passed 1st vote (w/o changes) at ASC 2024-Q3 meeting.

naughtont3 avatar Jul 18 '24 20:07 naughtont3

Passed 2nd vote at ASC 24Q4 so it is now accepted.

abouteiller avatar Oct 17 '24 19:10 abouteiller