helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

feat(config): add support for config.yaml file

Open hazzadous opened this issue 2 years ago • 4 comments

Support for specifying a config.yaml config file was added here. I'm not sure if this is the best way to add support for this, but would love to have the ability to specify the databases as part of the Helm Chart values.

hazzadous avatar Nov 11 '22 14:11 hazzadous

Thanks @hazzadous for contributing,

Please bump the chart version in Chart.yaml and ... From which version this config file was supported ? Can we also bump the metabase version accordingly ?

pmint93 avatar Nov 17 '22 03:11 pmint93

Hey @pmint93! I've bumped the chat version + would love to see this merged 🙏

From which version this config file was supported ? Can we also bump the metabase version accordingly ?

Looks like the change was added ~30 days ago: https://github.com/metabase/metabase/pull/25986

But I can't see it in the latest release :(

ellie avatar Nov 18 '22 13:11 ellie

Hah thanks @ellie 🤞 it makes it in the next release. #untested

hazzadous avatar Nov 18 '22 16:11 hazzadous

@hazzadous @ellie So I think we should wait for the release & official document of how to properly configure it

pmint93 avatar Nov 21 '22 00:11 pmint93