Philipp Hahn

Results 64 comments of Philipp Hahn

Using `vncdotool.api` creates a background-daemon-thread, which runs the _Twisted Reactor_: If not explicitly terminated by calling `api.shutdown()` it will keep running. While it is marked as a _daemon thread_, which...

The Twisted reactor is not restartable! A reactor is only started by the API when no-one is yet running. Stopping it after `with vncdotool.api.connect(…): …` would prevent you from using...

Yes ,#371 is a duplicate. Can you please close one in the favor of the other? #533 is also related: If type information is included with pyelftools itself instead of...

Yes, public API is my preferred thing, but elftools uses construct and things from there become public (by accident). And while collection information on the types to pass into a...

How do you want me to handle 🐛 like this in [`elftools/elf/descriptions.py`:250](https://github.com/eliben/pyelftools/blob/main/elftools/elf/descriptions.py#L250): ```python def describe_attr_tag_arm(…): d_entry = … if d_entry is None: … return … + d_entry[val] ``` > Value...

See https://github.com/eliben/pyelftools/pull/598 and https://github.com/eliben/pyelftools/pull/599 and https://github.com/eliben/pyelftools/pull/600 – more after that

See #602 for fixes for issues found by `mypy` while adding type hints. I'll push my local branch when it is again back in a working state: currently I have...

I have updated my branch https://github.com/eliben/pyelftools/compare/main...pmhahn:pyelftools:typing and pushed my latest changes: 1. There are several cleanup patches first, which I will again send via separate pull requests 2. [`pyright elftools`](https://github.com/microsoft/pyright)...

FYI: I have locally converted the tests to `pytest` and enabled _coverage_ reporting: ``` Name Stmts Miss Branch BrPart Cover Missing --------------------------------------------------------------------------------- elftools/__init__.py 1 0 0 0 100% elftools/common/__init__.py 0...

I have just pushed #611 for the type annotations. @Timmmm Maybe you can take a look, too?