rpma icon indicating copy to clipboard operation
rpma copied to clipboard

common: move on to the new coverage uploader

Open ldorau opened this issue 1 year ago • 5 comments

Move on to the new coverage uploader. The old bash uploader is long EOL now.

See: https://github.com/pmem/pmdk/pull/5548


This change is Reviewable

ldorau avatar Mar 14 '23 10:03 ldorau

.github/workflows/coverage.yml line 39 at r3 (raw file):

Previously, yangx-jy (Xiao Yang) wrote…

Is download-scripts.sh still necessary if we plan to use download-scripts.sh?

Sorry, I mean that we plan to use codecov/codecov-action@v3.

Code quote:

codecov/codecov-action@v3

yangx-jy avatar Mar 16 '23 05:03 yangx-jy

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)

a discussion (no related file):

Previously, ldorau (Lukasz Dorau) wrote… The last result (still "unusable report"): https://app.codecov.io/github/pmem/rpma/commit/ac0240e7d421d64310f4d0106f30432e886c5e59

if you believe you checked everything and are convinced you're doing everything right - you can ask Codecov team for help. They were usually very helpful on their forum.

lukaszstolarczuk avatar Mar 17 '23 08:03 lukaszstolarczuk

Previously, ldorau (Lukasz Dorau) wrote…

No, it still does not work

Is there any progress on this PR? ^_^

yangx-jy avatar May 08 '23 05:05 yangx-jy

Previously, ldorau (Lukasz Dorau) wrote…

The codecov/codecov-action@v3 action still does not work as expected: https://community.codecov.com/t/unusable-report-using-codecov-action-v3-bash-uploader-works-well/4223/17

It seems hard to make a progress on the issue. Do we have any other ideas? When do you prepare to do the release?

yangx-jy avatar May 16 '23 13:05 yangx-jy

Previously, ldorau (Lukasz Dorau) wrote…

v1.3.0 released: https://github.com/pmem/rpma/releases/tag/1.3.0

@ldorau Great. Thanks a lot for your help.

yangx-jy avatar May 25 '23 13:05 yangx-jy