pmdk icon indicating copy to clipboard operation
pmdk copied to clipboard

Add information about state #5419

Open Karolina002 opened this issue 2 years ago • 2 comments

This change is Reviewable

Karolina002 avatar Jul 22 '22 13:07 Karolina002

src/tools/pmreorder/statemachine.py line 388 at r3 (raw file):

Previously, Karolina002 (Karolina Bober) wrote…

Done.

This is list comprehension. Did you encounter any problems with generator expression?

karczex avatar Jul 27 '22 08:07 karczex

Codecov Report

Merging #5475 (c902f83) into master (776fde6) will increase coverage by 0.00%. The diff coverage is n/a.

:exclamation: Current head c902f83 differs from pull request most recent head fc0bdca. Consider uploading reports for the commit fc0bdca to get more accurate results

@@           Coverage Diff           @@
##           master    #5475   +/-   ##
=======================================
  Coverage   72.20%   72.20%           
=======================================
  Files         193      193           
  Lines       30337    30342    +5     
=======================================
+ Hits        21904    21909    +5     
  Misses       8433     8433           

codecov[bot] avatar Aug 11 '22 02:08 codecov[bot]

src/test/unittest/unittest.h line 784 at r31 (raw file):

	char *token;

	while ((token = strtok_r(tmp, delim, &tmp))) {

Heh, I should have noticed this bug earlier. strtok_r modifies the last argument, so FREE(tmp) will try to free something other than what was allocated earlier. I wonder why it doesn't blow up now...

marcinslusarz avatar Aug 25 '22 13:08 marcinslusarz