pmdk icon indicating copy to clipboard operation
pmdk copied to clipboard

Don't build PMDK twice / get rid of pmdk_debug directory

Open marcinslusarz opened this issue 6 years ago • 1 comments

Currently we build two sets of libraries from single source tree: stripped libraries intended for production and libraries with all debugging enabled.

We install release libraries to /usr/lib* and debug libraries to /usr/lib*/pmdk_debug.

Debug libraries are built with:

  • optimizations disabled
  • all symbols
  • logging (PMEM*_LOG_LEVEL, PMEM*_LOG_FILE)
  • light internal checks (asserts)
  • heavy internal checks (like "zeroed snapshot check" at the end of transactions or redo log corruption before processing)

The existence of 2 sets of libraries simultaneously built from one tree is quite unusual.

The proposal is to build only one set of libraries, install them to /usr/lib*, expand release builds to include some of the more useful but still lightweight debugging features and get rid of pmdk_debug directory.

Release libraries would be built with all symbols (and distributions would move those symbols to dbginfo packages) and with some lightweight logging.

Debug builds would be developer-only, so distributions would provide only release packages.

marcinslusarz avatar Mar 23 '18 15:03 marcinslusarz

See also: https://bugs.launchpad.net/ubuntu/+bug/1752378 (comment 15 and later)

marcinslusarz avatar Mar 23 '18 15:03 marcinslusarz

This improvement is not considered vital at the moment. So, we do not have the resources to fulfil your request. Sorry.

janekmi avatar Aug 30 '23 18:08 janekmi