libpmemobj-cpp icon indicating copy to clipboard operation
libpmemobj-cpp copied to clipboard

tests: add suppression for memcheck

Open lukaszstolarczuk opened this issue 1 year ago • 5 comments

ref. #1262


This change is Reviewable

lukaszstolarczuk avatar Jul 21 '22 09:07 lukaszstolarczuk

Codecov Report

Merging #1263 (fb91098) into stable-1.13 (f49772a) will decrease coverage by 1.78%. The diff coverage is 69.04%.

:exclamation: Current head fb91098 differs from pull request most recent head 7a78bb5. Consider uploading reports for the commit 7a78bb5 to get more accurate results

@@               Coverage Diff               @@
##           stable-1.13    #1263      +/-   ##
===============================================
- Coverage        95.52%   93.74%   -1.79%     
===============================================
  Files               53       53              
  Lines             6755     4573    -2182     
===============================================
- Hits              6453     4287    -2166     
+ Misses             302      286      -16     
Flag Coverage Δ
tests_clang_debug_cpp17 93.46% <68.96%> (-1.66%) :arrow_down:
tests_gcc_debug 90.37% <74.22%> (-2.00%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/libpmemobj++/allocator.hpp 71.42% <0.00%> (-7.82%) :arrow_down:
include/libpmemobj++/condition_variable.hpp 72.97% <0.00%> (-7.42%) :arrow_down:
include/libpmemobj++/container/array.hpp 97.33% <ø> (-0.80%) :arrow_down:
include/libpmemobj++/container/basic_string.hpp 98.69% <ø> (-0.63%) :arrow_down:
...j++/container/detail/concurrent_skip_list_impl.hpp 96.69% <ø> (-1.02%) :arrow_down:
include/libpmemobj++/container/segment_vector.hpp 93.15% <ø> (-2.30%) :arrow_down:
include/libpmemobj++/detail/ebr.hpp 95.74% <ø> (-2.89%) :arrow_down:
include/libpmemobj++/detail/pair.hpp 100.00% <ø> (ø)
include/libpmemobj++/detail/tagged_ptr.hpp 100.00% <ø> (ø)
include/libpmemobj++/detail/temp_value.hpp 100.00% <ø> (ø)
... and 68 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov[bot] avatar Jul 21 '22 10:07 codecov[bot]

this should be opened against stable-1.13 I think (@kilobyte reported the issue for 1.13)

Reviewed 2 of 2 files at r1, all commit messages. Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lukaszstolarczuk)

good point, re-based.

lukaszstolarczuk avatar Jul 21 '22 11:07 lukaszstolarczuk

I had to add a commit (cherry-picked from master) with the PMDK version update, due to CI failure.

lukaszstolarczuk avatar Jul 22 '22 10:07 lukaszstolarczuk

WFM. Tagged and bagged.

kilobyte avatar Jul 23 '22 09:07 kilobyte

for this PR to work (and the whole stable-1.13 branch), we'd have to apply 2 CI fixes: Windows workflow update and the newest PMDK installed (both cherry-picked here). I'm not sure if we want (and need) to do this now - we're applying these fixes into stable-1.9, and we can wait for them to be merged, bottom to top.

lukaszstolarczuk avatar Jul 25 '22 15:07 lukaszstolarczuk