scarlet icon indicating copy to clipboard operation
scarlet copied to clipboard

Check thresholding algorithm

Open pmelchior opened this issue 6 years ago • 1 comments

We never really tested update.threshold for robustness and when running on the HSC patches during the sprint we saw a number of cases, primarily for resolved extended objects where the bulge and disk had very different magnitudes, where the thresholding algorithm would entirely wipe out the disk.

So we need to revisit this algorithm again (I have the opened the referenced JIRA ticket for this) and decide the best way to incorporate some information about the background in the calculation so that we don't cut too high. In the meantime I would recommend going with the attitude that "it's better to do things correctly than fast" and just skip thresholding until we can fix it and test it more rigorously.

Originally posted by @fred3m in https://github.com/fred3m/scarlet/pull/107

pmelchior avatar Jul 02 '19 19:07 pmelchior

This method is now class ThresholdConstraint, but remains largely untested.

pmelchior avatar Dec 22 '19 21:12 pmelchior