light-the-torch icon indicating copy to clipboard operation
light-the-torch copied to clipboard

refactor patching logic

Open pmeier opened this issue 3 years ago • 4 comments

This is a very early prototype of a refactoring I have in mind. Posting this here for CI :innocent:

pmeier avatar Oct 27 '22 19:10 pmeier

Codecov Report

Merging #104 (6c544a6) into main (8e37c9b) will decrease coverage by 1.0%. The diff coverage is 58.0%.

:exclamation: Current head 6c544a6 differs from pull request most recent head c01c79a. Consider uploading reports for the commit c01c79a to get more accurate results

@@           Coverage Diff           @@
##            main    #104     +/-   ##
=======================================
- Coverage   83.6%   82.6%   -1.0%     
=======================================
  Files          5       6      +1     
  Lines        354     392     +38     
=======================================
+ Hits         296     324     +28     
- Misses        58      68     +10     
Flag Coverage Δ
unit 82.6% <58.0%> (-1.0%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
light_the_torch/_patch.py 80.6% <33.3%> (+5.1%) :arrow_up:
light_the_torch/_packages.py 65.2% <65.2%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Oct 27 '22 19:10 codecov[bot]

In the aftermath of #115, we need this even more.

pmeier avatar Jan 19 '23 09:01 pmeier

The general functionality is there, but we still need to merge with main. Will send more PRs against this one to minimize the risk botching this.

pmeier avatar Jan 23 '23 10:01 pmeier

The following PRs need to be ported:

  • [ ] #114
  • [ ] #115
  • [x] #116 -> 3058d645a001c23ab5765e97242c3b0ada62bd5c
  • [x] #117 -> 7df4d050f2bb129614eee75044a85887754859da, c01c79a796a2c4bc370a90c72274bb4512678f3a

pmeier avatar Jan 23 '23 13:01 pmeier