Philip Meier

Results 338 comments of Philip Meier

@martinRenou Your suggestions for the infinite loop does not work (at least not for `ipywebrtc==0.6.0`): ![finite_loop](https://user-images.githubusercontent.com/6849766/124320423-3239ab80-db7c-11eb-9b73-2e0fe1cd8754.png) Every time I execute the last cell again, it will add a line to...

I found if you display the recorder and hit the camera icon, this actually triggers an infinite loop. Looking at the code, I have no idea what is executed by...

That indeed works, thanks. Still, this feels kinda awkward since we didn't have `plot_gallery` config option before. I'm guessing it just assumes `plot_gallery=True` if nothing is set and then complains...

IIRC, we should enforce shuffling before sharding. cc @NicolasHug

@NivekT does the :+1: mean you agree with my suggestions and I can send a PR?

> We are currently exploring a plan to add a `BufferSpec` class (configuration) for buffer Is there a design document / issue for this? If not, what would a an...

I can't comment on the internal use case, but if the public API still accepts `int`'s and any sentinel for the infinite buffer, I'm ok with that.

> WDYT whether or not we should raise Error for negative value. If not raising value, we are kind supporting both sentinels for infinite. Let's not have two ways to...

> I don't think your pinning in `requirements-dev.txt` affects this at all: [pre-commit uses](https://pre-commit.com/#python) `pip install .` which will look at `pyproject.toml`, and set up an isolated build environment with...

I'm hitting the same plain `assert`, but I don't think it has anything to do with memory. Here is a MWE to reproduce that shows no noticeable changes on memory...