counterfact icon indicating copy to clipboard operation
counterfact copied to clipboard

Malformed vscode URL

Open cincauhangus opened this issue 1 year ago • 1 comments

Hello, I encountered some issues trying to launch IDE from the main page. Note: I am running on Windows.

Incorrect: https://github.com/pmcelhaney/counterfact/blob/412bb8b607317f63155f45e15ca9a19fe2be45ec/src/client/index.html.hbs#L233

vscode://file (missing trailing slash)

Correct: https://github.com/pmcelhaney/counterfact/blob/412bb8b607317f63155f45e15ca9a19fe2be45ec/src/client/rapi-doc.html.hbs#L24

vscode://file/ (trailing slash)

cincauhangus avatar Oct 01 '24 10:10 cincauhangus

Good catch. How did you even find this? Rapidoc at this point is undocumented and broken. I should remove that code altogether.

(If you'd rather me keep Rapidoc in and fix it, let me know. :))

pmcelhaney avatar Oct 02 '24 15:10 pmcelhaney

I found it when i tried to click on the path names on the counterfact page - http://localhost:3100/counterfact/

cincauhangus avatar Oct 07 '24 10:10 cincauhangus

Oh, I mixed up the correct and incorrect. I'll fix it. Thanks!

pmcelhaney avatar Oct 07 '24 17:10 pmcelhaney