Peter

Results 62 comments of Peter

> Just because the target is net7.0-windows that doesn't necessarily imply > that it's a desktop application. Indeed. This is a known gap. We don't really have a good solution...

@gladjohn Suggestion/request to not rebase, but merge; since rebase resets the changes/commits since last review (which makes a bit easier to review). ![image](https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/assets/34331512/f0cc15d2-85ca-4f73-864c-c017d8643999)

@gladjohn Please associate an appropriate issue with this PR.

@bgavrilMS Are these 3 PRs ready for review (this, uwp, xamarin removal)?

Created an docs issue to update the docs: https://github.com/MicrosoftDocs/microsoft-authentication-library-dotnet/issues/395

@alexmurari Thanks for the proposal. After team discussion, there is more design and work needed here. (Our PR process is described in the [contributing guide](https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/blob/dev/Contributing.md#before-writing-code), making sure a design is...

Based on the error telemetry - no, low ROI because errors are only a tiny amount of total requests. They do say there's [perf improvement](https://learn.microsoft.com/en-us/dotnet/api/system.net.http.socketshttphandler?view=net-5.0#remarks), so I would do it...

> How much time does this add to each build? I added a 5 minute wait in a test. These tests may also fail if multiple run concurrently...

Automation of this is currently blocked until everything's set up in the lab. The lab code is a placeholder for now. Tests can still be run manually.

@bgavrilMS Didn't R9 release some similar helpers (MS.Extensions namespace maybe?) Maybe worth looking into that too?