Paulo Matos
Paulo Matos
> One thing to note is that we should make sure not to reformat code that isn't ours. `FEXCore/Source/Common/SoftFloat-3e` isn't our code for example. Uff, I expected all code outside...
> > One thing to note is that we should make sure not to reformat code that isn't ours. `FEXCore/Source/Common/SoftFloat-3e` isn't our code for example. > > Uff, I expected...
> > > One thing to note is that we should make sure not to reformat code that isn't ours. `FEXCore/Source/Common/SoftFloat-3e` isn't our code for example. > > > >...
I have just pushed a new change. This one does several things: * Adds a wrapper to clang-format that takes `.clang-format-ignore` into consideration. It should be easy to use this...
> Also, [the `runInvocation()` signature](https://github.com/FEX-Emu/FEX/blob/cc9c80d79f6125b0fc2e16739c354cb496498f9b/unittests/ThunkLibs/generator.cpp#L188-L191) gets re-formatted into a single line, overstepping the column limit of 140 characters _a lot_. Any idea what's going on there? oh my - you're...
> Doing a quick scan through some files, and this looks quite nice > > I think we're missing: `AllowShortFunctionsOnASingleLine: Empty` from previous discussion from being applied, but aside from...
There has not been any comments as of late on this. Here's my suggestion: 1. I will work on CI integration in a different PR. 2. Choose a day for...
> There has not been any comments as of late on this. Here's my suggestion: > > 1. I will work on CI integration in a different PR. > 2....
> We probably want to prioritize reviewing & landing as much as possible this week then, else the conflicts are going to stink. (There are ways around this but it's...
As mentioned in discord: I added in #3572, a script to help reformat given a clang-format-ignore (cause there are files we don't want to reformat). For people working on branches,...