Mario Pietsch

Results 1305 comments of Mario Pietsch

dprint configuration settings can be found at: https://dprint.dev/plugins/typescript/config/ eslint config at: https://eslint.org/docs/latest/use/configure/

>I think you should use dprint integration with eslint, otherwise eslint formatting may conflict with eslint's. I did use the combination with dprint plugins for eslint. The disadvantage is that...

As I wrote with your configuration there where conflicts.

>You can do this just using dprint, but we need to add back integration later. There is not need to add eslint as a dev dependency to TW package.json. It's...

>As long as you don't need those autofix. ESLint autofix are done as soon as you save a code file, if the ESLint extension is installed in VSCode and the...

>Is dprint-integration properly installed? plugin:dprint-integration/disable-conflict should disable all eslint rules related to formatting. see https://github.com/so1ve/eslint-plugin-dprint-integration/issues/11#issuecomment-1506075574 Yes it was installed and configured properly. But if eslint rules are disabled anyway, then...

>Hi @pmario I think it might be easier to review this PR if we could remove the whitespace updates, and just include the changes necessary to get dprint installed and...

>Thinking about it, I thought we had decided to remove the function wrappers from modules in any case? In which case that should be done first as a separate PR?...

@Jermolene -- I did remove the **dprint** dependency. So The PR only contains stuff that is needed to remove the function wrapper and still get the right feedback in VSCode...

@Jermolene -- I did do some tests with the core plugins as I did create the PR the first time. I will test all core plugins and core editions again...