auto-reader-view icon indicating copy to clipboard operation
auto-reader-view copied to clipboard

Firefox Quantum compatibility

Open reaganch opened this issue 7 years ago • 9 comments

Any plans of revising this addon to make it compatible with Firefox Quantum (v57)?

reaganch avatar Nov 06 '17 10:11 reaganch

Yes, I've been working on it here and there when I get some spare time. Let me know if you're willing to help out or test and I can try to get a branch up with the current version.

pmarchwiak avatar Nov 07 '17 00:11 pmarchwiak

Would love to help test. Would need instructions on how to build the addon from your source code though.

reaganch avatar Nov 07 '17 00:11 reaganch

@reaganch I released a new version of the addon, 1.0.2, that's compatible with Quantum. It depends on an API method only available in v58 so you'll have to use Firefox Beta, Developer or Nightly to test. Feel free to comment here or file issues for any problems you find. Thanks for the help!

pmarchwiak avatar Nov 13 '17 17:11 pmarchwiak

Thanks. I'm running Firefox Beta right now, which is still at v57. Will install this as soon as it updates to v58 and test. Although I'm a bit unclear on how to install the addon to test. The zip file I download from the "Releases" section contains no xpi files.

reaganch avatar Nov 13 '17 20:11 reaganch

Ah, you're right. Currently Beta is at v57, which unfortunately won't work with the addon due to the aforementioned API incompatibility. You would have to try installing Developer or Nightly to test and then you should be able to install it via https://addons.mozilla.org/en-US/firefox/addon/auto-reader-view/ .

pmarchwiak avatar Nov 13 '17 20:11 pmarchwiak

Gotit. Will unfortunately not be able to test the addon this week since I'll be traveling. Will give it a spin next week and report here. Thanks again for putting this together!

reaganch avatar Nov 13 '17 20:11 reaganch

Just updated to Firefox v58.0b4 on Linux Mint 18.2 and installed the addon. Opening the news article http://www.aljazeera.com/news/2017/11/uk-leaders-academics-raise-alarm-saudi-crisis-171118195237495.html and clicking on the "Auto Reader Mode" button followed by "Enable" instantly makes the article appear in reader mode, but opening it again results in it appearing in regular mode instead of reader mode, although a green check mark appears on the "Auto Reader Mode" button. Clicking on the "Auto Reader Mode" button now allows the option of disabling on the domain.

reaganch avatar Nov 19 '17 05:11 reaganch

Thanks, I was able to reproduce this. I'll let you know when I have a fix ready.

pmarchwiak avatar Nov 20 '17 17:11 pmarchwiak

你的邮件我已收到~ 杨鹏飞

Xpider avatar Apr 26 '24 03:04 Xpider