Patryk Małek
Patryk Małek
#2708 only intended to make the implementation more DRY 🤔 Why do you think it solves this issue?
#3129 implemented it for `HTTPRoute` (and it also should work for other routes but no relevant tests have been added for those hence leaving those open).
> May be resolved by #2609 This is #2609 😅 Recursion overload
For now I've created a PR to make the project build again: https://github.com/kubernetes-sigs/ingress-controller-conformance/pull/94
So after looking at the results (that I can post later from a full test run) it seems that KIC doesn't fully pass those. Given that the upstream project is...
This is the test output that I ran against GKE 1.23 ( I ran this on ARM64 box with this patch so that the project builds and runs without errors:...
> Given that we seem to be at the edge of a fairly sizeable time investment if we want to see this issue through to completion and the fact that...
Not that I'm aware but it can be problematic (false negative) in case an error that's not `nil` gets asserted in the closure.
Agreed, ideally in such cases we would fail the whole test outright. But that should be explicitly noted/commented somewhere that in such a situation we don't tolerate the test to...
Given that we have not seen problems with the assertions as described in this issue let's leave this closed and revisit if we encounter any problems in the future.