Patryk Małek

Results 331 comments of Patryk Małek

Hi, sorry, swamped with other work assignments. Will comment when possible on this but spending a moment with this, it seems that KIC doesn't properly support TLSRoute (mostly due to...

Sorry for the delay on this issue. Talking about required changes in KIC: As https://github.com/kubernetes-sigs/gateway-api/pull/3458 has been merged upstream and clarified the supported modes for each route type can now...

> This may be due to the switch from `reverse-sshfs` to `virtiofs`. > > Try setting the `mountType` to `reverse-sshfs` and see if that works (because it uses a different...

Found it: https://lima-vm.io/docs/config/mount/#reverse-sshfs ``` mountType: "reverse-sshfs" mounts: - location: "{{.Home}}" writable: true ``` Seems to have done the trick! Do we need to document this for users somehow so that...

@randmonkey Made the change to remove the dependency on https://github.com/golang-collections/collections ( which is an 11 year old package) and used [`containers/list`](https://pkg.go.dev/container/[email protected]) instead. Also added some UTs. PTAL https://github.com/Kong/kubernetes-ingress-controller/commit/b90c664bfaa22324a1585423e3e2001d650fd1f8. Feel free...

I've moved on from this problem and added an exclusion for controller-runtime goroutines in the goroutine leak test: https://github.com/Kong/kubernetes-ingress-controller/blob/a32efd26867e255df611aa156ed9fcda291449f2/test/envtest/manager_envtest_test.go#L84-L87. As you can see in the snippet that I've added in...

We do set it to 0 for the tests where we observed the error: https://github.com/Kong/kubernetes-ingress-controller/blob/dd6538bf66f2e27805786fd6a21a7a93475f0323/test/envtest/run.go#L56-L59

I believe we could actually investigate the possibility of running webhook tests with envtest (and perhaps Kong Gateway started via `testcontainers`). With the introduction of Gateway Discovery tests like admission...

> I had an attempt to adapt our admission server boilerplate to controller-runtime so it's run as Manager's runnable, not separately as it is now. What would be the difference...