Pierre R. Mai

OSI SensorView is not expected to represent the output as it is coming from the sensor. It is expected to provide enough data from the environment simulation so that a...

I agree that the sensor specific fields (not only for radar) should also be added to DetectedStationaryObject. This would be an issue for the SensorModeling group, and could be done...

ISO 23150 A.2.48 Road Type is a road-level determination, hence has no bearing on the lane type which is a totally different concept (this is concerned with the role the...

@caspar-ai While the oneof makes the intent clearer, we are currently avoiding oneof (see the Actions in TrafficCommand for another instance where oneof might have been used but was backed...

Besides the general reservations that I have with the approach to ISO 23150 that I see (i.e. unclear use case), stuff like this seems particularly unclear: - This would move...

This seems to add files glpointcloud.cpp and pointcloud.cpp, but does not add them to the relevant CMakeLists.txt file, which causes the build failure seen in the CI: ``` CMakeFiles/osi-visualizer.dir/src/glwidget.cpp.o: In...

Hmmm, I have never seen a problem in Simulink with structured naming convention; can you be more specific? The reason that structured naming convention is required (from the beginning) is...

I'd be in favor of that, however would lead to repo renaming, etc.

OSI CCB 2022-11-21: Can be merged as is with necessary changes to resolve technical conflicts. Merge and cleanup done by @pmai.

> Looks good, but it needs to be linked somewhere in the menu of the documentation. Currently it can only be found via the search, right? Also, it should likely...