pm47

Results 85 comments of pm47

@btcontract I actually got bitten too! see 21c37e4

There are several more problems with this PR: - mutual close should also be supported in `WAIT_FOR_FUNDING_LOCKED` - the reconnection logic should handle the case where we have already sent...

FYI, here is a patch on `channel/Monitoring.scala` to track liquidity splices: ```diff diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala index fa15594cc0..4900a46467 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala +++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala @@ -57,10 +57,18 @@ object Monitoring {...

Please rebase 🙏

I am seeing the same thing with jeromq 0.4.3 on Windows 10, jdk 1.8.0_201. AFAICT this is easily reproductible, it happens 100% of the time, tried on two separate machines.

Unsigned integers are no longer experimental since Kotlin 1.5 : https://kotlinlang.org/docs/unsigned-integer-types.html.

> its this still pending? Yes >is the aliased scid used in the actual implementation private? Yes > is it leaking the funding tx of the channel when shared in...

Is this on the jvm ? Is there a chance the difference is more notable on native iOS ?

> I noticed too that lightning-kmp tests are slower now with the new serialization We do serialize (bin+json) at _all_ state transitions now (compared to only bin for some transitions),...