Victor M. Alvarez comments

Results 206 comments of


                                            Victor M. Alvarez

Ideas to improve "yr fmt"

> I haven't looked into it yet, but if possible I think all of this should be done in a library so it can be easily used by other tools....

Ideas to improve "yr fmt"

Introduction of line breaks at appropriate places, specially in the case of rule condition, is a pending improvement too. That's a bit more complicated, it's not a low hanging fruit...

Using yara-x in a Rust library and handling lifetime specifiers of Scanner

I believe you can achieve what you want with a bit of unsafe code: ```rust /// Wraps a yara_x::Rules, but preventing it from moving around in memory. struct PinnedRules{ rules:...

Using yara-x in a Rust library and handling lifetime specifiers of Scanner

@qjerome that doesn't work because `yara_x::Scanner` needs a reference to the rules in `MyScanner.rules`, you can create a scanner that receives that reference, but you can't move it into `MyScanner.scanner`.

Access the value passed into compiler.add_source(_, origin=<filename>)

That information is not currently exposed in the API.

Fail to build in Rust nightly

Closing as obsolete.

Go ReadFrom performance issues on large rule files

The `ReadFrom` not only loads the rules from the given reader, it also creates the Aho-Corasick automaton and produces the native code for the current platform. The time is probably...

Go ReadFrom performance issues on large rule files

Try this: ``` cargo build --release --features=logging RUST_LOG=info ./target/release/yr compile big_rule.yar -o big_rule.yarc RUST_LOG=info ./target/release/yr scan -C big_rule.yarc README.md ``` And paste here the logs you get. They should look...

Go ReadFrom performance issues on large rule files

That's strange, can you provide details about operating system, and CPU type?

Go ReadFrom performance issues on large rule files

Can you try the same on Windows without WSL?