jekyll-bootstrap icon indicating copy to clipboard operation
jekyll-bootstrap copied to clipboard

Consistency Pass?

Open groundh0g opened this issue 10 years ago • 2 comments

Any objections to making a pass through the _includes/JB/* scripts to make them self-consistent, based on issue #42?

  • use include.param rather than state variables

logic would replace missing include parameter values with previously-expected state variables so that existing implementations aren't affected

  • include detailed usage notes, with examples
  • formatted for readability
  • wrap logic in {% capture jbcache %}...{% endcapture %}{% assign jbcache=nil %} to avoid polluting HTML with tons of whitespace.

groundh0g avatar Mar 03 '15 13:03 groundh0g

After giving it a little more thought, I believe this task should be pushed to the next release (v 0.5.0).

That's when I'll be cleaning up the development branch. If I do the cleanup pass before, it'll likely make merging development changes much harder.

groundh0g avatar Mar 17 '15 19:03 groundh0g

This needs to happen later rather than sooner. Refactoring early will introduce more merge conflicts. Bumping to next release to keep this release clean.

groundh0g avatar May 25 '15 11:05 groundh0g