plumed2 icon indicating copy to clipboard operation
plumed2 copied to clipboard

UPPER_WALLS or LOWER_WALLS and PBCs

Open GiovanniBussi opened this issue 5 years ago • 2 comments

It looks like applying PBCs on the difference between the current CV value and that of the wall might not be the correct thing to do. See this post for a practical example.

Should we just replace:

const double cv=difference(i,at[i],getArgument(i));

with

const double cv=getArgument(i)-at[i];

?

I am not totally sure this is the right thing to do. Maybe adding a NOPBC flag to UPPER_WALLS and LOWER_WALLS to disable PBC?

GiovanniBussi avatar Dec 09 '20 13:12 GiovanniBussi

I think that the point is that a single upper/lower wall on a periodic CV is meaningless, anyway for u/l walls possible the correct thing is to calculate the distance as cv=getArgument(i)-at[I]; but also throw an error if the CV is periodic (in case suggesting to remove the periodicity using COMBINE)

carlocamilloni avatar Jan 17 '23 22:01 carlocamilloni

Hi Devs, I am trying to use the upper and lower walls bias modules. I wonder if there is any news about this potential issue...?

Clownshift avatar Oct 12 '23 11:10 Clownshift