sccm icon indicating copy to clipboard operation
sccm copied to clipboard

feat(sccm): Works with multiple configurations

Open tolemac opened this issue 1 year ago • 13 comments

Hi again!

I have fear about https://github.com/pluginsGLPI/sccm/pull/109, this PR have serious changes and we are working in production with code that is not in this repository, after #109 has been merged I think it will be more difficult for us to add this change, due to it we would like to make a effort to add this PR to the repo.

This PR is the same as https://github.com/pluginsGLPI/sccm/pull/102, we think that it's a good feature and it has been working all days in the last year in our GLPI installation.

The feature is fully functional the only thing missing is a button to add a new SCCM Configuration.

I would like to add this but I haven't been able to...

Can you help me?

tolemac avatar Feb 23 '24 09:02 tolemac

Yeah! :D

I have fix some odd things that made that menu didn't work at expected. I have been able to do it looking at #109 changes!!!

I will prepare the commit and push here.

tolemac avatar Feb 23 '24 10:02 tolemac

Done! it's ready for review.

It has add button and the configs can be purged, config form use standard form html with navigation and historical log.

tolemac avatar Feb 23 '24 12:02 tolemac

@stonebuzz how to have the commits to keep your commits? If I commit and push changes on my repo/branch will we lose your 2 commits? Or can I checkout your changes? (don't know how)

tolemac avatar Mar 13 '24 07:03 tolemac

git fetch my_repo (yours)

git pull --rebase my_repo my_branch (multi)

stonebuzz avatar Mar 13 '24 07:03 stonebuzz

@stonebuzz I have a question, what is the showtable.php file for?

tolemac avatar Mar 13 '24 09:03 tolemac

I have a question, what is the showtable.php file for?

an old thing that's about to blow up ^^

don't worry about it now, I'll clean up later

stonebuzz avatar Mar 13 '24 09:03 stonebuzz

Let me know when you've finished so I can do another review

stonebuzz avatar Mar 13 '24 09:03 stonebuzz

Let me know when you've finished so I can do another review

I think the only thing missing is the autoincrement issue, I have answered the review, I'm waiting for your response.

tolemac avatar Mar 13 '24 09:03 tolemac

Hi @tolemac

I've corrected and refactored the code. Can you try this new version?

stonebuzz avatar Apr 05 '24 08:04 stonebuzz

Hi @tolemac

I've corrected and refactored the code. Can you try this new version?

I have pushed the code to production.

I have deactivate de plugin, and reactivate it. Create a new configuration, enter on edition change several fields save changes, exit to list page, enter on details again, delete permanently ...

I have execute on demand Collect and Push automatic actions.

All work as expected, no errors on php-errors.log and sccm.log files.

It's ok for me.

tolemac avatar Apr 05 '24 10:04 tolemac

Thanks, @tolemac,

I'll have it tested by a few people who use it before I merge it.

stonebuzz avatar Apr 05 '24 12:04 stonebuzz

Thanks, @tolemac,

I'll have it tested by a few people who use it before I merge it.

Totally agree!

Thanks in advance. I will stay tunned.

tolemac avatar Apr 05 '24 12:04 tolemac

@stonebuzz some news about that? still in testing?

Best regards!

tolemac avatar Jul 23 '24 11:07 tolemac