formcreator icon indicating copy to clipboard operation
formcreator copied to clipboard

fix: adjust dashboard widget height

Open ccailly opened this issue 1 year ago • 2 comments

Changes description

Checklist

Please check if your PR fulfills the following specifications:

  • [ ] Tests for the changes have been added
  • [ ] Docs have been added/updated

References

Closes #N/A

Correct dashboard widget height in install.php. Previous pull request, #3306 refactored UI of widgets but missed updating install.php. A subsequent commit updated install.php but set widget height to 1 instead of the correct value 2.

This PR fixes the widget height value to 2.

ccailly avatar Apr 09 '24 13:04 ccailly

As discussed with @Rom1-B above and IRL, it's probably wiser not to change the widget size during an update. It's possible that some users may have manually modified their widgets, so only new installations of the plugin will benefit from the new widget size.

ccailly avatar Apr 12 '24 12:04 ccailly

Hi

As discussed with @Rom1-B above and IRL, it's probably wiser not to change the widget size during an update. It's possible that some users may have manually modified their widgets, so only new installations of the plugin will benefit from the new widget size.

Actually, the plugin takes measures to prevent users to modify its mini dashboard. Noone should be able to modify it (neither super-admins). This is why it should be safe to modify it programmatically

btry avatar Apr 12 '24 13:04 btry