strapi-plugin-config-sync icon indicating copy to clipboard operation
strapi-plugin-config-sync copied to clipboard

Published 20 hours ago • verified publisher icon pluginpal

fix: relations export

Open salmanm opened this issue 3 years ago • 2 comments

What does it do?

Describe the technical changes you did.

Why is it needed?

Describe the issue you are solving.

How to test it?

Provide information about the environment and the path to verify the behaviour.

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

salmanm avatar Sep 12 '22 09:09 salmanm

Hi @salmanm,

The PR is still marked as Draft. Is that correct? Or is it ready for review? Also the integration tests are failing. Are you seeing this?

boazpoolman avatar Sep 15 '22 17:09 boazpoolman

@boazpoolman Yes I kept the PR draft as I'm not sure if the approach is a good fit for all cases. Since I'm not super familiar with the codebase, I refrained from spending too much time without knowing if it's in the right direction. I just opened it for discussion and ideas. I'd appreciate if you could do a sanity check to see if its not gonna break cases other than oneToMany. If you think it's in the right direction, I'd be happy to add/fix tests.

salmanm avatar Sep 19 '22 06:09 salmanm