statify icon indicating copy to clipboard operation
statify copied to clipboard

ci: add workflow to run wp plugin checks

Open stklcode opened this issue 1 year ago • 1 comments

Add a new workflow to run the plugin-check-action when pushing or merging to stable.

We build the plugin first and re-use the .distignore file to generate the final plugin package. Otherwise we should run into several issues with files. This list is also used for deployment, so the results should be as representative as it gets.


Run on current develop branch shows one error:

Error: The Stable Tag in your readme file does not match the version in your main plugin file. Your Stable Tag is meant to be the stable version of your plugin, not of WordPress. For your plugin to be properly downloaded from WordPress.org, those values need to be the same. If they’re out of sync, your users won’t get the right version of your code.

That's correct and intentional on the develop branch. Hence we should start running the full set of checks only before merging to stable.

and a few warnings

Warning: One or more tags were ignored. Please limit your plugin to 5 tags.

(now fixed, see #293)

Warning: Use of a direct database call is discouraged. Warning: Direct database call without caching detected. Consider using wp_cache_get() / wp_cache_set() or wp_cache_delete().

(already known from PHPCS)

stklcode avatar Sep 21 '24 15:09 stklcode

Forgot about this PR, the check workflow is now active (f0c3a4008805c2c5e8b19414c69ccdf58d10779c)

stklcode avatar Nov 11 '24 17:11 stklcode