statify icon indicating copy to clipboard operation
statify copied to clipboard

[I18n] Add JavaScript i18n, typo and brand names

Open pedro-mendonca opened this issue 2 years ago • 2 comments

This PR includes the following:

  • [x] Add JavaScript i18n to proper deal with JavaScript strings, including plurals, variables, etc
  • [x] Fix ~statify~ Statify brand name
  • [x] Typo

pedro-mendonca avatar Nov 24 '23 13:11 pedro-mendonca

Thanks Pedro!

I think we should add wp-i18n to the JS dependencies explicitly. On the dashboard it should be present anyway, so it works without, but relying on that is probably not best practice, is it?`

https://github.com/pluginkollektiv/statify/blob/83a29f1ab18e3df5b9a964b417e234431e2b83ff/inc/class-statify-dashboard.php#L126-L132

ping #253 for another WP 5.0+ argument

stklcode avatar Nov 25 '23 14:11 stklcode

@stklcode I've added the wp-i18n core script to the dependencies as you've requested. Thanks for the review :)

pedro-mendonca avatar Apr 12 '24 09:04 pedro-mendonca