statify icon indicating copy to clipboard operation
statify copied to clipboard

Track internal search queries

Open florianbrinkmann opened this issue 2 years ago • 5 comments

This PR:

  • ensures search queries are stored in the DB (lowercased, and never with a trailing slash)
  • Adds a Statify_Dashboard::parse_target() method that is called for the targets list in the widget. It makes sure the search query items are not just displayed as /?s=[…]

Looks like this:

Bildschirm­foto 2023-03-18 um 14 09 48

Closes #220

florianbrinkmann avatar Mar 18 '23 13:03 florianbrinkmann

Have you discussed about creating an own section for this instead of adding this data to the "views" section?

Zodiac1978 avatar Mar 19 '23 10:03 Zodiac1978

I didn't (maybe other parts of the team did). But a dedicated section seems like a good idea and might integrate well into the planned extended evaluation features. Should be removed from the pages view then or maybe just grouped together as "Search".

stklcode avatar Mar 19 '23 10:03 stklcode

Didn’t think about adding an own section, but like the idea, then we also do not need the Search query: prefix

florianbrinkmann avatar Mar 19 '23 11:03 florianbrinkmann

Changed it so that the search queries are displayd in its own list

Screenshot of the Statify widget with the new area for search queries

florianbrinkmann avatar Mar 19 '23 12:03 florianbrinkmann

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Mar 20 '23 10:03 sonarqubecloud[bot]