antispam-bee icon indicating copy to clipboard operation
antispam-bee copied to clipboard

Add report spam link

Open Zodiac1978 opened this issue 4 years ago • 12 comments

Add report spam action link to spam list (#73)

Zodiac1978 avatar Aug 13 '20 19:08 Zodiac1978

After the discussion: This is a nice feature. Thank you @Zodiac1978 for introducing it :heart:

Imo good to merge.

websupporter avatar Aug 15 '20 05:08 websupporter

Maybe this is important to know. This PR adds the report link just to spam links. This is because of the already existing code.

Should we add this report link to all comments?

Zodiac1978 avatar Aug 17 '20 10:08 Zodiac1978

@websupporter I don't know why Travis is still using the old behat test. Even if I restart the job it is not using the changed test and therefore fails because of the changed string.

Zodiac1978 avatar Aug 27 '20 11:08 Zodiac1978

You would need to merge the master I think. But currently master seems to fail for coding standards :smile:

Imo its good to merge from the test side, as we know it just fails for the outdated test setup.

websupporter avatar Aug 28 '20 06:08 websupporter

Ah sorry, I see it now I think. @schlessera did the first commit into an old branch (d53187d244ba28b7da2cb5f819576b416a8e345e) and than it was merged it into this one here (dd4ab8655bbb84a3f41a824e42be7c1bbe58375c). This branch here has the updated tests, this is why the first test fails while the second works imo.

websupporter avatar Aug 28 '20 06:08 websupporter

Due to missing feedback I have punted this PR to milestone 2.10. :(

Zodiac1978 avatar Sep 17 '20 09:09 Zodiac1978

Without clear information about the privacy implications I don't see a possible path forward here.

Additionally I will close the form and delete the excel sheet, because I am the owner of it to protect me.

If anyone is seeing a possible solution to the whole problem, please add your comment. Otherwise I don't see another way as to close the hole issue/PR and remove any report mechanism due to unknown law implications.

Zodiac1978 avatar Dec 21 '20 10:12 Zodiac1978

  • [ ] Add modal before sending data
  • [ ] Use own form for storing the data

florianbrinkmann avatar Feb 10 '21 10:02 florianbrinkmann

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar May 27 '21 10:05 sonarqubecloud[bot]

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 5 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Dec 23 '21 15:12 sonarqubecloud[bot]

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jan 31 '22 14:01 sonarqubecloud[bot]

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Mar 10 '22 08:03 sonarqubecloud[bot]