plugdata icon indicating copy to clipboard operation
plugdata copied to clipboard

Flagging of incompatible objects when Compile mode is switched on or off does not work as expected.

Open kisyaki opened this issue 2 months ago • 6 comments

I found an issue with how incompatible objects are flagged when switching Compile mode on and off.

It does not flag objects that should be flagged when you switch to Compile mode. Only flags them when created, then don't un-flag them when switching out of Compiled mode but then and un-flags them when switching back to Compiled mode in which they should be flagged. (see screen cap where I'm using the hvcc incompatible [sigmund~])

https://github.com/user-attachments/assets/506f3aef-6705-471f-afb5-babaec6f6fb1

kisyaki avatar Oct 28 '25 18:10 kisyaki

The topic title isn't very clear on what is the issue you are discussing here. I don't think it is "inconsistent".

I'd say it's a kind of feature request of missing UX.

What we would expect is that: if we enable compiled mode the patch should notify all the incompatibilities. If we disable compiled mode all the highlighted objects should turn to normal.

dromer avatar Oct 28 '25 18:10 dromer

Thanks! that's a good clarification.

The inconsistency I'm referring to is that it takes away the flag of an previously correctly flagged object when switching back to Compile mode. So it is switching the flagging, just in the wrong way for some objects.

kisyaki avatar Oct 28 '25 18:10 kisyaki

I think 57870a7b9 fixes it?

timothyschoen avatar Dec 08 '25 17:12 timothyschoen

Nice, quick test says it works!

@kisyaki can you confirm?

dromer avatar Dec 08 '25 18:12 dromer

I can still reproduce it in the latest nightly (abafe8887) MacOS 15.6.1, but not consistently, sometimes it works as expected, sometimes it has this behavior:

https://github.com/user-attachments/assets/193c3ad7-00f5-4ec0-af2e-16fcfe278315

kisyaki avatar Dec 09 '25 08:12 kisyaki

ah lol, so it works one way and then toggles the wrong way around

very close to working though!

dromer avatar Dec 09 '25 10:12 dromer

Alright, d7fb6dd26 fixes that. Thanks for reporting and testing!

timothyschoen avatar Dec 16 '25 17:12 timothyschoen