plugdata icon indicating copy to clipboard operation
plugdata copied to clipboard

Bug: opening an abstraction marks it as editted

Open dromer opened this issue 1 year ago • 13 comments

When opening an abstraction it immediately is marked as edited even though we didn't change anything. Trying to close it will ask us to save the changes.

2024-12-16_07-30

I thought we had this issue before, but it was fixed (can't find it though). So could be a regression somewhere.

dromer avatar Dec 16 '24 06:12 dromer

Ah, gonna fix that!

Btw: changed your mind about syntax highlighting?

timothyschoen avatar Dec 16 '24 12:12 timothyschoen

@timothyschoen I have had to reset the config several times and I work on 3-4 different machines so haven't set my own config yet.

Still not 100% convinced this looks good though :P

dromer avatar Dec 16 '24 12:12 dromer

Hmm, I can't reproduce the issue on another machine. Both are running the latest nightly ..

dromer avatar Dec 16 '24 12:12 dromer

Can't reproduce it atm. Will re-open if it re-appears ..

dromer avatar Dec 17 '24 19:12 dromer

Seems like @porres is running into this issue as well, so worth investigating

timothyschoen avatar Dec 17 '24 19:12 timothyschoen

Hmm, with latest develop on another machine it's now also giving this issue (which I couldn't reproduce two days ago ..)

So yeah definitely something strange and inconsistent going on :thinking:

dromer avatar Dec 18 '24 10:12 dromer

This still happens regularly on latest nightly, btw.

I've still not detected a straightforward pattern that allows it to be easily reproduced :#

dromer avatar Jan 28 '25 11:01 dromer

I encounter this as well. Also don't see any pattern why.

tmhglnd avatar Feb 03 '25 22:02 tmhglnd

It sometimes also happens for subpatches, which is odd since changes would go to the main patch.

From what I can tell only the sub-patch is marked as edited and when closing it we get a warning.

dromer avatar Feb 05 '25 10:02 dromer

I think I've found a pattern: it asks to save an abstraction if the parent patch if was opened from is marked dirty. That's at least one case I can reproduce some of the time

Edit: seems like this worked yesterday, but it doesn't happen anymore now...

timothyschoen avatar Feb 05 '25 12:02 timothyschoen

Except it also happens when the parent patch hasn't been modified at all.

It's definitely very hard to reproduce, as the same patch may give this behavior one time, but not the next session.

dromer avatar Feb 05 '25 12:02 dromer

I did another fix, hope it doesn't happen anymore now

timothyschoen avatar Feb 07 '25 01:02 timothyschoen

I'll update my local builds and play around .. we'll see what happens :P

dromer avatar Feb 07 '25 06:02 dromer

@dromer @tmhglnd Anyone still has this happening on recent builds?

timothyschoen avatar Jul 15 '25 14:07 timothyschoen

I haven't had it in a while and actually forgot about it :D

(although I think it has happened since Feb 7th ..)

dromer avatar Jul 15 '25 14:07 dromer

So far I haven't encountered it either.

tmhglnd avatar Jul 22 '25 17:07 tmhglnd