plugdata icon indicating copy to clipboard operation
plugdata copied to clipboard

Add a Vanilla theme

Open porres opened this issue 1 year ago • 2 comments

Hi, I see many options for configuration in PlugData, and a few make it more Vanilla.

I propose other configuration options and also a pre configured Vanilla mode.

You already provide straight lines that never bend or curve, squared objects.

What seems to be missing is

  • [ ] allow one to configure the colors of inlets/outlets
  • [ ] have an option to set inlets/outlets to the extremes of the object.
  • [ ] allow themes to set the font of comments and etc (see https://github.com/plugdata-team/plugdata/issues/1691 )
  • [ ] Allow us to distinguish the signal connection so we can make it thicker and pure black

porres avatar Jun 24 '24 17:06 porres

and why the dot on subpatches in classic mode huh?

Screenshot 2024-06-24 at 14 22 48

porres avatar Jun 24 '24 17:06 porres

and why the dot on subpatches in classic mode huh?

I see what this is now, will open a new issue about it

porres avatar Jun 24 '24 20:06 porres

Inlet & Outlet colour is already in theme: image

Would you like more control over this?

  • Connection Data Colour
  • Connection Signal Colour
  • Connection Gem Colour
  • Iolet Data Colour
  • Iolet Signal Colour
  • Iolet Gem Colour

AlexMitchellMus avatar Jul 05 '24 04:07 AlexMitchellMus

Hi, I'm checking the nightly build, cool! I guess I missed things as they don't seem all too clear what the options actually are.

I'm testing the "object & connection style", and classic mode.

What I see is that these colors are for like edit mode, huh? And that when I'm on run mode the inlets/outlets are actually grayed out. Can we have a setting to keep the chosen color for the inside area or something?

As for the alignment issues, they're still there.

I see there is still a minimum offset, I wonder if that is the limit.

And I see that there are still discrepancies between objects and number boxes

by looking closely, I see that the inlet of a number box is a bit narrower, so the alignment fails a bit.

Screenshot 2024-07-05 at 02 00 22

porres avatar Jul 05 '24 05:07 porres

canvas text should be 'object text', right? and it should be in "OBJECT" section

and canvas dots colour -> "background dots in edit mode" (no need to mention 'colour', it is obvious we're setting a colour)

data color -> "data inlet/outlet in edit mode" - should be in "OBJECT" section as well

'Signal' -> 'signal connection' 'Gem' -> 'Gem connection'


'Inlet/Outlet area' is misleading, it made me think it was the inner area of the inlet/outlet, but you actually mean "top and bottom" area

Anyway, for the Object and IOlet style, I think the color for Inlet/Outlet should not be grayed out and we don't need then any other setting

porres avatar Jul 05 '24 05:07 porres

The "object and iolet style" could also embrace other elements like message and number boxes

Screenshot 2024-07-05 at 03 05 19

We can see that the message boxes and number box have this black area that in Vanilla is just non existent. I see plugdata uses this method to make things squared, but in such a 'clean' visual style, the pure harsh black areas stand out pretty bluntly on the eyes and it differs a lot in style to how these look in Vanilla

porres avatar Jul 05 '24 06:07 porres

Message and number box style was added by Alex now too! I think our vanilla look is vanilla enough for now at least :)

timothyschoen avatar Oct 07 '24 14:10 timothyschoen

Message and number box style was added by Alex now too!

where can I set it though? testing nightly build... don't see it

I think our vanilla look is vanilla enough for now at least :)

I'd hope this issue to be active and not closed until we have an actual preset name for theme style called 'vanilla', cause that's the main point... and also until we deal with this https://github.com/plugdata-team/plugdata/issues/1691 then i think it's good enough and good to go

porres avatar Oct 07 '24 17:10 porres

where can I set it though? testing nightly build... don't see it

Set the "object flag style" setting to "Outlined". You can also just reset your themes and load the classic theme

until we have an actual preset name for theme style called 'vanilla'

Right now this is the "classic" (and classic-dark) theme. That's fine right?

timothyschoen avatar Oct 07 '24 18:10 timothyschoen

Right now this is the "classic" (and classic-dark) theme.

Oh, but it didn't work out of the box for me, maybe because I had old settings saved or something?

porres avatar Oct 07 '24 18:10 porres

That's fine right?

could be fine. I still think that a mode named 'Vanilla' would be more straight forward

porres avatar Oct 07 '24 18:10 porres

I will reboot this into a new issue that gathers other related issues besides https://github.com/plugdata-team/plugdata/issues/1691

porres avatar Oct 07 '24 19:10 porres

ok, see closing in favor of https://github.com/plugdata-team/plugdata/issues/1882 as a reboot of this and other related issues

porres avatar Oct 07 '24 19:10 porres