tbc-credit-card-payment-gateway-php-lib icon indicating copy to clipboard operation
tbc-credit-card-payment-gateway-php-lib copied to clipboard

Published 20 hours ago • verified publisher icon plugandpay

Multi IP environment fix

Open kotso opened this issue 7 years ago • 2 comments

kotso avatar Apr 01 '17 09:04 kotso

Hi,

Comment suggests "IP address of customer..." this is confusing. As we are setting client IP addresses here https://github.com/wearede/tbcpay-php/blob/master/src/WeAreDe/TbcPay/TbcPayProcessor.php#L184

While I understand what you meant with customer, it was confusing at first glance.

From: https://curl.haxx.se/libcurl/c/CURLOPT_INTERFACE.html Sets the interface name to use as outgoing network interface. The name can be an interface name, an IP address, or a host name.

Maybe use desc from curl docs and reword comment for clarity.

sandrodz avatar Apr 02 '17 10:04 sandrodz

Updated code, remove src_ip and added client_ip_address to be curl interface also.

kotso avatar Apr 04 '17 11:04 kotso